On Wed, 12 Feb 2020 13:21:03 GMT, Frederic Thevenet
<[email protected]> wrote:
> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be larger than the running platform's
> maximum supported texture size, was addressed in openjfx14.
> The fix, based around the idea of capturing as many tiles of the maximum
> possible size and re-compositing the final snapshot out of these, is
> currently only attempted after the original, non-tiled, strategy has already
> failed.
> This was decided to avoid any risk of regressions, either in terms of
> performances and correctness, while still offering some relief to the
> original issue.
>
> This follow-on issue aims to propose a fix to the original issue, that is
> able to correctly decide on the best snapshot strategy (tiled or not) to
> adopt before applying it and ensure best performances possible when tiling is
> necessary while still introducing no regressions compared to the original
> solution.
modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java
line 1527:
> 1526: private int computeOptimumTileSize(int size, int maxSize,
> AtomicBoolean isDivExact) {
> 1527: for (int n = 2; n <= 6; n++) {
> 1528: int optimumSize = size / n;
It would be helpful if you add explanation about the constants 2 and 6 here.
-------------
PR: https://git.openjdk.java.net/jfx/pull/112
