On Thu, 23 Apr 2020 10:51:05 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> John Hendrikx has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental >> views will show differences compared to the previous content of the PR. The >> pull request contains one new commit since >> the last revision: >> 8242548: Honor line spacing in Labeled reflow calculation > > Marked as reviewed by aghaisas (Reviewer). I added a comment clarification and passed the line spacing to the ellipsis height calculation as well (just in case there is a multi line ellipsis). The test indeed doesn't quite cover the change, the StubTextLayout is not advanced enough to actually do line wrapping calculations (it ignores wrap height), and would need to be updated. ------------- PR: https://git.openjdk.java.net/jfx/pull/173
