On Thu, 23 Apr 2020 11:22:18 GMT, John Hendrikx <[email protected]> wrote:
>> Marked as reviewed by aghaisas (Reviewer). > > I added a comment clarification and passed the line spacing to the ellipsis > height calculation as well (just in case > there is a multi line ellipsis). > The test indeed doesn't quite cover the change, the StubTextLayout is not > advanced enough to actually do line wrapping > calculations (it ignores wrap height), and would need to be updated. @hjohn Updates to a PR under review should be done as additional commits. Please do not force push to your branch. This makes it more difficult for reviewers, since the incremental diffs from the last time it was reviewed are lost. A force push of your branch should only be used in extraordinary circumstances. ------------- PR: https://git.openjdk.java.net/jfx/pull/173
