On Thu, 23 Apr 2020 12:31:34 GMT, Arun Joseph <ajos...@openjdk.org> wrote:
>> fillPath() and fillRect() functions in >> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) >> use Image::drawPattern() for applying patterns as fill. But drawPattern() >> doesn't use patternTransform argument as >> ImagePattern doesn't have the same attribute. So, the final image won't be >> transformed. > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Add CanvasTest This works for the HW accelerated pipeline, but you need to also modify the SW pipeline and J2D pipeline (used for printing). See [SWPaint::computeImagePatternTransform](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWPaint.java#L280) and the ImagePattern case in [J2DPrismGraphics::toJ2DPaint](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/prism/j2d/J2DPrismGraphics.java#L282). In the J2D pipeline case, you will have more work to do, since it doesn't use a pattern transform that I can see. ------------- Changes requested by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/190
