On Mon, 11 May 2020 22:27:27 GMT, Nir Lisker <[email protected]> wrote:
>>> I will review this too anyway. >> >> Thank you. That will be helpful. > > As I started my review I noticed that `unbind` does not null-check its > argument `dependencies` like `bind` does and it > can lead to NPEs. If it is out of scope for this PR to fix this, a new issue > should be filed. The fix looks correct and the tests pass. I just wonder why the change to reflection-based construction with `bindingMockClassConstructor`? ------------- PR: https://git.openjdk.java.net/jfx/pull/198
