On Tue, 12 May 2020 15:56:32 GMT, Nir Lisker <[email protected]> wrote:
> The fix looks correct and the tests pass. I just wonder why the change to > reflection-based construction with > `bindingMockClassConstructor`? The Parameterized test constructs some standard Binding objects to run multiple tests with. This works fine if those objects are immutable (or aren't modified during the tests). My new test however does modify them, and other tests would fail with such modified objects (as `unbind` was called on some). So I rewrote this a little bit to construct fresh objects for each test, and for that I used some reflection magic to avoid having to write a specific test for each of the 8 binding types. ------------- PR: https://git.openjdk.java.net/jfx/pull/198
