On Mon, 11 May 2020 04:12:22 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Issue: >> When tabs are permuted as mentioned in the issue description as, >> 1. TabPane.getTabs().setAll(tab0, tab1) >> 2. TabPane.getTabs().setAll(tab0, tab1, tab2, tab3); >> the tab headers do not get permuted in same order as `TabPane.getTabs()`. >> >> => tab headers should be shown in order as tab0, tab1, tab2, tab3. >> => but are show in order as tab2, tab3, tab0, tab1 >> >> Cause: >> Newly added tabs(tab2, tab3) are not inserted at correct index. The index >> `Change.getFrom()` (0) used from Change does >> not remain valid after the tabs to be moved(tab0, tab1) are removed from >> `tabsToAdd` list. >> Fix: >> Use the index of first newly added tab, from `TabPane.getTabs()`, which >> would be always reliable. >> >> Verification: >> No existing tests fail due to this change. >> Added a system test which fails without and pass with fix. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > review-update: change test name tests are passing, what else can we achieve with a fix :) Looks good! ------------- Marked as reviewed by fastegal (Author). PR: https://git.openjdk.java.net/jfx/pull/201
