On Thu, 21 May 2020 10:05:25 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> It's a task to support cross-control/skin testing for recurring issues (like
>> memory leaks on switching skins)
>>
>> Basically, there's a utility class
>> - to access lists of all control/classes,
>> - to access/create all behaviors
>> - has alternative skins classes for all controls and utility to
>> install/replace skins
>>
>> POC:
>> - has test examples (not run in normal testing due to not following naming
>> conventions) for using
>> - changed SkinDisposeContractTest to use
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlBehaviorTestExample.java
> line 52:
>> 51: @RunWith(Parameterized.class)
>> 52: public class ControlBehaviorTestExample {
>> 53:
>
> This test does not execute when run as part of :controls:test. We need to
> rename this class (and file) name to end with
> 'Test'. I tried doing it and lot of failures are seen.
that's the point - they are examples of how-to use it and see our tasks :)
Will address your other comments in a minute - and add two real tests (on
skin/behavior memory leaks with the
misbehaving classes removed: then we'll have both the passing classes and
informal ignores on what's going wrong.
-------------
PR: https://git.openjdk.java.net/jfx/pull/223
