On Thu, 21 May 2020 07:16:15 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> It's a task to support cross-control/skin testing for recurring issues (like >> memory leaks on switching skins) >> >> Basically, there's a utility class >> - to access lists of all control/classes, >> - to access/create all behaviors >> - has alternative skins classes for all controls and utility to >> install/replace skins >> >> POC: >> - has test examples (not run in normal testing due to not following naming >> conventions) for using >> - changed SkinDisposeContractTest to use > > modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlSkinFactoryTest.java > line > 91: >> 90: Control control = createControl(controlClass); >> 91: Skin<?> old = replaceSkin(control); >> 92: } > > An assertion can be added about old skin and new skin objects being different. oops ... forgot, will do ------------- PR: https://git.openjdk.java.net/jfx/pull/223
