On Tue, 27 Oct 2020 11:37:40 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> If we use our own loader - we would need to dispose that as well :) >> >> Also, I found approach (1) of using reference at test class level and >> cleaning it up in cleanup method after the test is more suitable as in >> ButtonTest, the assertion happens in event handler. Wrapping it in >> try..finally will need additional code. >> I will push the changes in a moment. > > nit-picking: we already do dispose our own loader (or cleanup our stage), > don't we :) > > the change looks good Can you please mark it as Approved? ------------- PR: https://git.openjdk.java.net/jfx/pull/337
