On Tue, 24 Nov 2020 21:28:29 GMT, Matthias Bläsing <github.com+2179736+matthiasblaes...@openjdk.org> wrote:
> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that > the java class com.sun.webkit.MainThread can be found be the JNI > function FindClass. This is only true if the class is loadable by the > system class loader. > > One such case is when the OpenJFX modules are loaded from a new > ModuleLayer. To fix this, the reference to the class needs to be loaded > from when a JNI call from Java into native code is active. In that case > FindClass uses the classloader associated with that method. > > The test code can be executed by running: > > cd tests/manual/web/dataurl > ../../../../gradlew run I'll plan to look at this next week. I have a general question and a comment: 1. Would it be possible to turn the test into an automated one? Possibly using some of the same techniques that the ModuleLauncherTest does? 2. All of the new files need a proper copyright header (including the new `build.gradle`). ------------- PR: https://git.openjdk.java.net/jfx/pull/360