On Tue, 15 Dec 2020 22:51:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Matthias Bläsing has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated according to review comments >> >> - The text and formatting was adjusted according to the raised concerns. >> - The test was modified with a 15000ms timeout as is the case for other >> tests in the systemTests project >> - A safeguard was added in the launched child JVM, that terminates the >> child after 15000ms is it did not exit normally >> - The detection of a successful test was moved to a ChangeLister on the >> load worker state. It is assumed, that the worker success state is >> similar to the DOMContentLoaded event. The latter is fired after >> synchronous javascript was executed and that would be late enough to >> "see" the DOM update of the title. >> >> It was validated, that the test still fails without the fix and succeeds >> with it. > > The updates look good. Two additional comments on the test. One more thing: can you enable GitHub actions test execution for your repo? See [this message](https://github.com/openjdk/jfx/pull/360/checks?check_run_id=1564422863) from the Skara bot. ------------- PR: https://git.openjdk.java.net/jfx/pull/360
