On Wed, 25 Nov 2020 15:56:05 GMT, Jonathan Vusich 
<github.com+31666175+jonathanvus...@openjdk.org> wrote:

>> While this does fix the specific problem, it introduces a new one. If the 
>> labels are initially too big, but after resizing the window would now fit, 
>> it does not recompute the orientation. This means that you are left with 
>> labels that are rotated even when they don't need to be.
>
> @kevinrushforth Thank you for catching that. Do you think it would be 
> acceptable to simply rotate the labels back to zero if the user expands the 
> window?

@JonathanVusich Once a review is in progress, please don't force-push your 
branch without a compelling reason, since that makes it harder to do 
incremental reviews. In the future, we recommend `git merge master` rather than 
`git rebase master`, since the former doesn't require force-pushing.

-------------

PR: https://git.openjdk.java.net/jfx/pull/342

Reply via email to