On Mon, 1 Feb 2021 23:13:02 GMT, Jonathan Vusich 
<github.com+31666175+jonathanvus...@openjdk.org> wrote:

>> I do see that there are no changes from last time, which is good, so it will 
>> be fine for this time.
>> 
>> When ready, you can add the new test by pushing a new commit.
>
> @kevinrushforth I was not aware of that, thank you for letting me know! 
> I wrote a new test for vertical axes and discovered that there were more 
> issues with axis layout calculations, which I also addressed.
> 
> I also found out that the layout tests sometimes fail without a short pause 
> using `Util.sleep()`. I don't really like having to add sleeps, but I did 
> find that it got rid of any test flakiness.

wondering about the system test - what stands in the way to add a simple 
"normal" unit test?

-------------

PR: https://git.openjdk.java.net/jfx/pull/342

Reply via email to