On Fri, 23 Apr 2021 16:57:54 GMT, Florian Kirmaier <fkirma...@openjdk.org> 
wrote:

>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8264127:
>   More changes based on codereview.
>   Simplified the tests, we are now using for both cases "test-factory-methods"

I now use method for both cases with various indizes. 
I've removed the initial test, and now I'm only using the reusable methods.
The cases are now also symmetric, except the outlinder which causes the "if" in 
the first test. `assertChangeIndexToEditing(-1, 0); `. Should i remove it?

-------------

PR: https://git.openjdk.java.net/jfx/pull/441

Reply via email to