On Fri, 23 Apr 2021 16:52:14 GMT, Florian Kirmaier <fkirma...@openjdk.org>
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java
>> line 867:
>>
>>> 865: @Test
>>> 866: public void testChangeIndexToEditing3_jdk_8264127() {
>>> 867: assertChangeIndexToEditing(1, -1);
>>
>> hmm .. don't quite understand this: the list's editing state shouldn't be
>> changed and here it is never editing. What's the intention?
>
> I guess it doesn't make sense. Probably missunderstanding somewhere. Should i
> remove? This would also get rid of the if in the test.
yes, remove it: the focus of this issue is that the cell sync's its own editing
state on updateIndex off/to list editing index - I think that implies the list
always editing with a valid editingIndex :)
-------------
PR: https://git.openjdk.java.net/jfx/pull/441
