I have a question about this.

Why would you make this part of JavaFX directly instead of offering it as a dependency that people can include in their project?

As far as I know, it is possible to register custom URL handlers in Java, which should be used automatically by JavaFX assuming it constructs its URL's in the standard way when extracting them from the CSS.

This can be done since Java 9+ via URLStreamHandlerProvider. You need to store the name of your provider in `META-INF/services`.

Any reason why this route isn't being taken?

--John

On 21/05/2021 19:58, Michael Strauß wrote:
This PR adds support for loading images from [inline data 
URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely 
supported by web browsers. This enables developers to package small images in 
CSS files, rather than separately deploying the images alongside the CSS file.

-------------

Commit messages:
 - Added data-URI loading support for images

Changes: https://git.openjdk.java.net/jfx/pull/508/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=508&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8267551
  Stats: 437 lines in 8 files changed: 414 ins; 9 del; 14 mod
  Patch: https://git.openjdk.java.net/jfx/pull/508.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/508/head:pull/508

PR: https://git.openjdk.java.net/jfx/pull/508

Reply via email to