On Sat, 5 Jun 2021 16:12:36 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> `resource` is never `null` at this point, and it is already trimmed. Also, 
>> contrary to the comment, I cannot see this method being used anywhere in 
>> tests, so I made it private.
>
> If that is guaranteed by all callers of this method (which is easier to check 
> now that you made it private), this is fine.

This method is only used once, and only after `resource` has already been 
dereferenced. So if it was indeed `null`, we would have errored out with 
`NullPointerException` before calling this method.

-------------

PR: https://git.openjdk.java.net/jfx/pull/508

Reply via email to