well I guess eclipse users won't see the sources anymore if they are
moved, as we expect the src.zip next to the jar file [1] if I read my
code appropriately.
I filed [2] to adapt our code
Tom
[1]
https://github.com/eclipse-efx/efxclipse-eclipse/blob/master/bundles/tooling/org.eclipse.fx.ide.jdt.core/src/org/eclipse/fx/ide/jdt/core/internal/BuildPathSupport.java#L80
[2] https://github.com/eclipse-efx/efxclipse-eclipse/issues/85
Am 23.06.21 um 15:50 schrieb Kevin Rushforth:
Are there any IDE users who are currently having problems as a result of
this? If not, I'll retarget this for a future release.
-- Kevin
On 6/14/2021 1:15 PM, Kevin Rushforth wrote:
We deliver a set of modular jars in the lib directory of the
standalone JavaFX SDK. We also deliver src.zip for use by IDEs into
that same directory. If you add the lib directory to your
application's module path in your IDE, it will try to load src.zip as
if it were a jar file, and will fail. This is a pain point for
developers using the SDK. This problem has been raised on the mailing
list a couple of times, and I think it's time to fix it. This issue is
tracked in JBS by JDK-8258499 [1].
I propose to move the src.zip file from the lib directory to the top
directory of the SDK.
Alternatively, we could create a new directory for src.zip (either a
sibling of lib or sub-directory under lib). However, I think it would
be easier to find in the top dir of the SDK, and I don't see the need
for a new directory just to hold src.zip.
Before I create the PR and the associated CSR, I'd like to hear
developer's opinions on this.
-- Kevin
[1] https://bugs.openjdk.java.net/browse/JDK-8258499