On Thu, 24 Jun 2021 22:25:53 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > > modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 474: > >> 472: * encoded name of a filesystem file, to which the platform printer >> 473: * driver should spool the rendered print data. >> 474: * <p> > > Can you add a sentence indicating that the URL needs to be a `file:` URL? And > indicate what happens if it isn't (I presume it is ignored)? As a potential user of this API I have to ask, why would this be a URL instead of a File or Path ? Particularly if only "file:" URLs will be valid. I can't think of a scenario where it won't always be an extra inconvenience to convert the path I have to a URL. ------------- PR: https://git.openjdk.java.net/jfx/pull/543
