On Thu, 24 Jun 2021 22:42:00 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8223717: javafx printing: Support Specifying Print to File in the API
>> - 8223717: javafx printing: Support Specifying Print to File in the API
>
> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 541:
>
>> 539: * @since 17
>> 540: */
>> 541: public String getOutputFile() {
>
> This should be final (as should the setter). I see that other getter and
> setter methods in this class are also non-final, but we shouldn't propagate
> this mistake.
>
> Also, you don't need javadoc comments on the getters and setters, since it
> will copy them from the property (and add appropriate links).
But the JobSettings class is final .. is it still necessary ?
-------------
PR: https://git.openjdk.java.net/jfx/pull/543
