On Mon, 28 Jun 2021 19:47:39 GMT, Phil Race <p...@openjdk.org> wrote:
>> This enhancement adds the String property outputFileProperty() to the
>> JobSettings class.
>> The value should be a string that references a local file encoded as a URL.
>> If this is non-null and set to a location that the user has permission to
>> write to,
>> then the printer output will be spooled there instead of the printer, so
>> long as the platform printing system supports this.
>> The user can of course also set a print-to-file destination in the platform
>> printer dialogs which may over-ride what the application set. But now the
>> application can also see what it was set to, and cancel or alter it if
>> necessary.
>>
>> A simple manual test is provided, manual mainly because the few real
>> printing functional tests are all manual as they are only useful if run with
>> a printer configured.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8223717: javafx printing: Support Specifying Print to File in the API
The API looks fine now, although I may have some minor wording suggestions
after I do another pass tomorrow. Go ahead and file the CSR and move it to
proposed as soon as you can to see if Joe has any comments in parallel with our
finishing the review.
I also need to do some testing on Mac and Linux (the manual test now works as
expected on Windows).
modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 503:
> 501: * If a {@code SecurityManager} is installed and it denies access to
> the
> 502: * specified file a {@code SecurityException} may be thrown.
> 503: * @defaultValue an empty String
Minor: I recommend either `string` (lower case) or `{@code String}`.
Very minor: can you move the `@defaultValue` below the blank like with the
other javadoc tags?
-------------
PR: https://git.openjdk.java.net/jfx/pull/543
