On Thu, 1 Jul 2021 00:15:13 GMT, Phil Race <p...@openjdk.org> wrote: >> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 481: >> >>> 479: * such as Postscript or PDF, and the application intends to >>> distribute >>> 480: * the result instead of printing it, or for some other reason the >>> 481: * application does not want physical media (paper) emitted by the >>> printer. >> >> Very minor: maybe consider combining the first three paragraphs into a >> single paragraph? > > well .. I usually like a short paragraph that succinctly says what it does as > the first paragraph > > Anyway I've re-read all this and I prefer it as it is.
ok >> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 486: >> >>> 484: * equivalent to null, which means output is sent to the printer. >>> 485: * So in order to reset to print to the printer, clear the value of >>> 486: * this property by setting it to null or an empty string. >> >> This doesn't flow as well as it could. I think you only need to mention once >> that `null` is the same as an empty string, and then you can just say "empty >> string". Maybe something like this? >> >> >> The default value is an empty string, which means output is sent to the >> printer. So in order to reset >> to print to the printer, clear the value of this property by setting it to >> an empty string. A value >> of {@code null} is treated as an empty string. > > But I don't say it twice. I say >> The default value is an empty string, which is interpreted as unset, >> equivalent to null, > > and >> clear the value of this property by setting it to null or an empty string. > > which is somewhat different and makes i t very clear that either will work .. > > So I think this is all fine and flows as intended. ok ------------- PR: https://git.openjdk.java.net/jfx/pull/543