On Mon, 12 Jul 2021 18:50:34 GMT, Phil Race <p...@openjdk.org> wrote:
> - Make various setters and getters and properties final as needed > - Move documentation to the property so the setters and getters inherit it, > with an exception for the special case of JobSettings.setPageRanges() > - Override toString() on the properties in JobSettings so it doesn't delegate > to the JobSettings class. > - Add a manual test program just so you can see what toString() does. No pass > or fail, just informative. > > This will need a CSR but I won't create that until the review is done. This pull request has now been integrated. Changeset: 8b8cea23 Author: Phil Race <p...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/8b8cea23d1fd5c1c149e0143e2f6bf3312b5ab2e Stats: 433 lines in 4 files changed: 265 ins; 134 del; 34 mod 8269638: Property methods, setters, and getters in printing API should be final Reviewed-by: kcr, psadhukhan ------------- PR: https://git.openjdk.java.net/jfx/pull/574
