On Fri, 3 Sep 2021 13:23:39 GMT, Marius Hanl <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected comment tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
> line 366:
>
>> 364: */
>> 365: public static Background fill(Paint fill) {
>> 366: return new Background(new BackgroundFill(fill, null, null));
>
> null **CornerRaddii** and null **Insets** will use **CornerRadii.EMPTY** and
> **Insets.EMPTY**. Maybe we should use those here instead so it's more clear
> for anyone having a look in the source code? I also always use those instead
> of null.
> Same for **BorderStroke**
Are you talking about the implementation or the code? I guess both, since the
`@implSepc` indicates what this call is equivalent to. I don't have a strong
opinion on this one.
-------------
PR: https://git.openjdk.java.net/jfx/pull/610
