On Mon, 25 Oct 2021 17:47:38 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) >> - There are still 20 javadoc warnings remaining in javafx.controls module >> and 3 warnings remaining in javafx.web module. The root cause is different >> and they will be addressed under >> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996) > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > fix review comments Two minor comments. The rest looks great. modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java line 179: > 177: * HTML element. Note that, like the HTML style attribute, this > 178: * variable contains style properties and values and not the > 179: * selector portion of a style rule. It would be good to add a sentence here with the information (which was formerly in the getter) that a value of `null` is converted to the empty string. modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line 508: > 506: * <p>The maximum height of the tabs in the TabPane.</p> > 507: * @return the maximum height of the tabs > 508: */ In reverting this, you introduced a whitespace (indentation) change. ------------- PR: https://git.openjdk.java.net/jfx/pull/646
