On Thu, 16 Dec 2021 21:26:29 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> This PR updates the `CONTRIBUTING.md` guide to address the following:
>> 
>> 1. Clarify the process for adding new features / API changes, specifically 
>> that they must be discussed on the mailing list as the first step.
>> 2. Add a link to the mailing list in the section regarding contributing bug 
>> fixes.
>> 3. Remove the text about cross-linking the PR and JBS issue, and add a note 
>> that the Skara tooling takes care of this
>> 4. Remove the section about manually resolving the JBS issue, and add a note 
>> that the Skara bot automatically does this when the PR is integrated.
>> 5. Suggest the use of the "/reviewers 2" and "/csr" commands when appropriate
>> 6. Update the note regarding which JDK(s) to use.
>
> Kevin Rushforth has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Minor updates to address pending review comments that I did last year, but 
> forgot to push

CONTRIBUTING.md line 57:

> 55:     A developer with an active OpenJDK ID can file a bug directly in JBS.
> 56: 
> 57: TIP: A GitHub pull request (PR) should not be the first time we hear 
> about your proposed change to OpenJFX. Unless clearly identified as a Draft 
> or work-in-progress (WIP), we will usually close a pull request that isn't 
> associated with an existing bug report. Reading the policies below will help 
> you in getting your change approved.

forward reference to Draft or WIP, so maybe add (as explained later)?

CONTRIBUTING.md line 179:

> 177: with the environment variable `JAVA_HOME` referencing the path to Java 
> home for
> 178: your JDK installation. By default, tests use the same runtime as 
> `JAVA_HOME`.
> 179: Currently OpenJFX builds are running on JDK 11 through JDK 15. JDK 14 is 
> recommended.

JDK 17

-------------

PR: https://git.openjdk.java.net/jfx/pull/303

Reply via email to