On Thu, 16 Dec 2021 21:26:29 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a link to the mailing list in the section regarding contributing bug >> fixes. >> 3. Remove the text about cross-linking the PR and JBS issue, and add a note >> that the Skara tooling takes care of this >> 4. Remove the section about manually resolving the JBS issue, and add a note >> that the Skara bot automatically does this when the PR is integrated. >> 5. Suggest the use of the "/reviewers 2" and "/csr" commands when appropriate >> 6. Update the note regarding which JDK(s) to use. > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > Minor updates to address pending review comments that I did last year, but > forgot to push CONTRIBUTING.md line 252: > 250: > 251: TIP: a pull request is _not_ the starting point, since that skips the > first two important steps and jumps right into > 252: "given this new feature, and an API definition that specifies it, please > review my proposed implementation". I wonder if we should add something like "A PR is also not the end point, as code that is included in the repository should be maintained." I don't think that really belongs here, but it is a point I always check when reviewing a PR: what is the estimated maintenance for this PR? It might be better in the "Code Reviews" section on the OpenJFX wiki though. ------------- PR: https://git.openjdk.java.net/jfx/pull/303
