On Fri, 17 Dec 2021 17:15:22 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v5] > > modules/javafx.media/src/main/native/gstreamer/plugins/mfwrapper/mfwrapper.cpp > line 646: > >> 644: >> 645: if (SUCCEEDED(hr) && dwFlags != MFT_OUTPUT_STATUS_SAMPLE_READY) >> 646: return FALSE; > > If the previous call failed, should you really continue with the following > call to `ProcessOutput`? Yes, if call GetOutputStatus() fails we need to call ProcessOutput(). It is based on documentation. See https://docs.microsoft.com/en-us/windows/win32/medfound/basic-mft-processing-model#process-data ------------- PR: https://git.openjdk.java.net/jfx/pull/649
