On Thu, 7 Jul 2022 20:37:29 GMT, Andy Goryachev <[email protected]> wrote:

> This PR does not fix apps/ project. In fact, I think .project in apps/ should 
> be removed, and instead we should create individual projects, either for a 
> group (i.e. samples, toys), or for each application (i.e. Robot, 3DViewer).
> 
> This work depends on the cleanup. We could probably do it in a separate bug. 
> What do you think?

That's fine, but I saw that you changed the 3DViewer and Ensemble8 files, and 
there are still errors there, so either leave apps completely out of this PR or 
bring it to a point where there are no errors.

As in my branch that I linked above in the review comment, I also created a 
separate project for each app. The `apps` project itself still needs a .project 
file because it's a gradle project that is created automatically by the gradle 
build. It doesn't need to be a Java project though, so the .project file can 
have the gradle nature only.

-------------

PR: https://git.openjdk.org/jfx/pull/804

Reply via email to