On Thu, 7 Jul 2022 22:26:17 GMT, Andy Goryachev <[email protected]> wrote:

> No, my workspace (jfx) was imported as a gradle project. I think it created a 
> bunch of .project and .classpath files that never worked - I could not get 
> them to compile. I had to reset all of them

That's what I wrote in the instructions - gradle creates its own project files 
that are wrong (it's not smart enough to handle modular projects yet), and they 
need to be reverted to those in the repo, or in this PR in this case.

I updated to the latest commit and imported as Gradle projects in a new 
workspace (and reverted to this PR's Eclipse files). I still get an error on 
3DViewer: `The type java.lang.Class cannot be resolved. It is indirectly 
referenced from required .class files`. This error points at some configuration 
issue. If you don't get this error for some reason then we can continue and get 
there when we do the apps folder, otherwise it should be fixed.

In addition, If I import as Java projects (not as Gradle), `buildSrc` still has 
project files that should be removed (and apps is a mess, which is fine for 
now).
`tests` also has project files that need to be fixed (`tests` includes the 
Gradle project `systemTests`) if they are imported this way. The errors are the 
ones I posted in my review comment. If you want to work on `tests` on a later 
PR that's also fine because there is some work to do there.

-------------

PR: https://git.openjdk.org/jfx/pull/804

Reply via email to