On Tue, 19 Jul 2022 10:36:07 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Do not recalculate total estimated size recursively. >> >> In the (unlikely) event that the recalculation triggers a new recalculation >> (e.g. when the height of a Cell is changed), do not start this recalculation. >> The cache and cache size may become inconsistent if a recursive calculation >> is started. >> This fixes JDK-8290348 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Fix test (so that it fails before the patch to VirtualFlow) Looks good. I confirm that both the visual test and updated unit test fail without the fix and pass with the fix. I left one question inline, but I doubt it is a problem. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/836
