On Sun, 17 Jul 2022 18:59:22 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Do not recalculate total estimated size recursively. >> >> In the (unlikely) event that the recalculation triggers a new recalculation >> (e.g. when the height of a Cell is changed), do not start this recalculation. >> The cache and cache size may become inconsistent if a recursive calculation >> is started. >> This fixes JDK-8290348 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > fix issue with IDE-indicated unused statement modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 3113: > 3111: adjustPosition(); > 3112: } > 3113: recalculating = false; Is it likely that this method might get an exception? I was wondering whether the assignment to false should be in a try / finally. If there is no probable way an exception could occur, or if an exception is non-recoverable (which is quite possible), then no need for a try / finally. ------------- PR: https://git.openjdk.org/jfx/pull/836
