On Thu, 16 Jun 2022 08:01:05 GMT, Ambarish Rapte <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGShape3D.java
> line 201:
>
>> 199:
>> 200: /**
>> 201: * If no lights are in the scene, add a default white point light
>> at the camera's. The light uses the default
>
> minor: `at the camera's` -> `at the camera's (eye) position`
>
> Additionally would recommend to move the first line `If no lights are in the
> scene, add a default white point light at the camera's position.` above line
> number 128 before calling `createDefaultLight`
I thought that the code
if (noLights(lights)) {
createDefaultLight(g);
speaks for itself: if there are no lights, add a default light. The details of
what that light is are in the method doc. Can still add a comment there.
-------------
PR: https://git.openjdk.org/jfx/pull/789
