On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> - updated .classpath entries in apps/ > - added utf-8 prefs in .settings/ I'm don't think that this is the right approach with the apps. I think that each app should be its own project. See the branch I linked in the previous PR. I don't see why the containing folders like samples and toys should be java projects. buildSrc/.classpath line 10: > 8: <classpathentry kind="lib" exported="true" > path="../build/libs/antlr-runtime-3.1.3.jar"/> > 9: <classpathentry kind="lib" exported="true" > path="../build/libs/stringtemplate-3.2.jar"/> > 10: <classpathentry kind="lib" exported="true" > path="../build/libs/swt-debug.jar"/> Why does buildSrc need to be a project? It contains no relevant sources. modules/javafx.graphics/.classpath line 5: > 3: <classpathentry kind="src" path="src/main/java"/> > 4: <classpathentry kind="src" path="build/gensrc/jsl-prism"/> > 5: <classpathentry kind="src" path="build/gensrc/jsl-decora"/> How do you not get errors on these on Mac/Linux if they are not declared optional? Additionally, you need the hlsl folders as shown in the mailing list. ------------- PR: https://git.openjdk.org/jfx/pull/858
