On Mon, 1 Aug 2022 18:47:14 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> - updated .classpath entries in apps/
>> - added utf-8 prefs in .settings/
>
> buildSrc/.classpath line 10:
> 
>> 8:   <classpathentry kind="lib" exported="true" 
>> path="../build/libs/antlr-runtime-3.1.3.jar"/>
>> 9:   <classpathentry kind="lib" exported="true" 
>> path="../build/libs/stringtemplate-3.2.jar"/>
>> 10:   <classpathentry kind="lib" exported="true" 
>> path="../build/libs/swt-debug.jar"/>
> 
> Why does buildSrc need to be a project? It contains no relevant sources.

It probably does not, the file was added in 2013 as a part of
RT-31216: Ensure NetBeans development in Gradle build works [Eclipse files]

Turns out, eclipse can work with nested projects.  Shows multiple hits when 
looking for resources, but it does.

I've added a separate project for ColorCube app as an example, but since this 
PR is about making all directories to build on Eclipse, I'd rather not fix all 
the apps in this PR.  (I would keep ColorCube as a reference though).

> modules/javafx.graphics/.classpath line 5:
> 
>> 3:   <classpathentry kind="src" path="src/main/java"/>
>> 4:   <classpathentry kind="src" path="build/gensrc/jsl-prism"/>
>> 5:   <classpathentry kind="src" path="build/gensrc/jsl-decora"/>
> 
> How do you not get errors on these on Mac/Linux if they are not declared 
> optional?
> 
> Additionally, you need the hlsl folders as shown in the mailing list.

As with any multi-stage project, we need to run 'gradle sdk' (or perhaps 
'gradle sdk apps' for good measure) to build these directories.  Then, in 
Eclipse, clean all projects.  These steps produce a working configuration.

I do not see hlsl folders being build on Mac.  Are these being built on 
windows/linux?
If these are platform-specific, then we should add them to the gradle build.  
Maybe an additional target that creates the empty directories, and upon which 
sdk depends on.

-------------

PR: https://git.openjdk.org/jfx/pull/858

Reply via email to