Sure, I'll do that when I get a chance. As long as you set VS150COMNTOOLS, you shouldn't ever need to edit them, but it might be useful as a sanity check to compare with yours. Our GHA builds only set that one variable (and do not set MSVC_VER or VSINSTALLDIR).

    VS150COMNTOOLS: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Auxiliary\\Build"

-- Kevin


On 8/12/2022 8:06 PM, Nir Lisker wrote:
Kevin, can you update the windows_tools.properties file for the build page on the wiki [1] for VS 2022 since I see that we updated to use that version?

[1] https://wiki.openjdk.org/pages/viewpage.action?pageId=66650334

On Sat, Aug 13, 2022 at 2:06 AM Nir Lisker <nlis...@gmail.com> wrote:

    I see the file
    under \VC\Tools\MSVC\14.33.31629\include\vcruntime.h of the VS
    installation. The file calling it is under C:/Program Files
    (x86)/Windows Kits/10/include/10.0.17763.0/ucrt\corecrt.h.
    Is it supposed to look for some env variable to find it? I
    have MSVC_VER, VSINSTALLDIR and VS150COMNTOOLS all set. I don't
    remember needing anything else.

    On Sat, Aug 13, 2022 at 1:30 AM Kevin Rushforth
    <kevin.rushfo...@oracle.com> wrote:

        vcruntime.h is included with the Visual Studio compiler and
        has been for
        ages. I can't think of anything recently that would have changed
        relative to that.

        -- Kevin


        On 8/12/2022 2:12 PM, Nir Lisker wrote:
        > Hi,
        >
        > I have just run gradle clean and gradle build, and I'm
        getting an error:
        >
        > C:/Program Files (x86)/Windows
        > Kits/10/include/10.0.17763.0/ucrt\corecrt.h(10): fatal error
        C1083:
        > Cannot open include file: 'vcruntime.h': No such file or
        directory
        >
        > Indeed, vcruntime.h is not in that folder. Do I need to update
        > something, like VS?
        >
        > - Nir

Reply via email to