On Tue, 2 Aug 2022 15:10:50 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/Mtl1VS.hlsl line 32:
>
>> 30: //float2 transformTexture(float2 t) { return t; }
>> 31:
>> 32: VsOutput main(VsInput vsInput) {
>
> The input struct name was earlier passed from build.gradle,
> https://github.com/openjdk/jfx/blob/08ec9c8781a57b49a13a2b7febbe33172ebc1a5a/build.gradle#L2344
>
> This change needs to be reflected in build.gradle. so,
> either
> 1. Remove `"/DVertexType=ObjVertex",` in build.gradle
> OR
> 2. Change `"/DVertexType=ObjVertex",` in build.gradle to
> `"/DVertexType=VsInput",` and revert the type function parameter here.
>
> I would recommend option 2, as it would remind us to use this approach in
> future if we needed multiple types of vs input structs. But I leave it to you.
What do you mean by "revert the type function parameter here"? Doesn't the type
parameter match after a change to the gradle file?
-------------
PR: https://git.openjdk.org/jfx/pull/789
