On Tue, 2 Aug 2022 17:38:06 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vs2ps.h line 26:
>
>> 24: */
>> 25:
>> 26: struct PsInput {
>
> The `struct VsOutput` is the actual input to pixel shader. Naming this struct
> as `PsInput` may not be correct.
> I would recommend to have only one struct that is `PsInput` and move member
> variable texD of `VsOutput` to `PsInput`.
> In vertex and pixel shaders, use correct names for the variables of `PsInput`.
> In vertex shader, the variable would be names as output, and in pixel shader
> as input.
> For example:
> https://github.com/caioteixeira/GameEngines/blob/master/lab5/Assets/Shaders/Phong.hlsl
I opted to alias the names and use `VsOutput` in the vertex shader and
`PsInput` in the pixel shader. See if that works for you.
-------------
PR: https://git.openjdk.org/jfx/pull/789
