On Fri, 12 Aug 2022 18:15:37 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> - added Skin.install() >> - javadoc changes for Skinnable.setSkin(Skin) >> >> no code changes for Skinnable.setSkin(Skin) yet. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 8290844: review comments even with the code you just provided, it will fail as described earlier. the problem, as i see it, is that dispose() of the previous skin is executed after the new skin is attached. literally nothing can be done to work around the issues caused by this design mistake, but to fix it outright - dispose() the old skin first, then install the new one. then, and only then, all the requirements concerning user-settable properties and clean uninstallation can be met. ------------- PR: https://git.openjdk.org/jfx/pull/845
