On Wed, 7 Sep 2022 20:49:13 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8290844: review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 35:
>
>> 33: * A user interface control is abstracted behind the {@link Skinnable}
>> interface.
>> 34: * <p>
>> 35: * A Skin implementation should generally avoid modifying its control
>> outside of
>
> I think this is a good start. As discussed elsewhere, additional
> implementation notes for Skin implementers would be helpful.
added @ImplNote to install().
-------------
PR: https://git.openjdk.org/jfx/pull/845
