On Thu, 15 Sep 2022 17:12:14 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> Using Weak*Listeners eliminates the memory leak.

This looks like it will eliminate the leak. Using weak listeners like this 
follows the same pattern as used by some of the other skins. I'll review and 
test it next week.

modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/ScrollPaneSkinTest.java
 line 916:

> 914:     }
> 915: 
> 916:     // this should be in common test utils

There already is one that you can use, 
[JMemoryBuddy](https://github.com/openjdk/jfx/blob/master/modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java).

-------------

PR: https://git.openjdk.org/jfx/pull/900

Reply via email to