On Wed, 28 Sep 2022 08:41:42 GMT, Ambarish Rapte <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293444: memory buddy
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/ScrollPaneSkinTest.java
> line 912:
>
>> 910:
>> 911: // one instance is still held by the 'content' label
>> 912: assertTrue("uncollected objects=" + ct, ct <= 1);
>
> May be the assert can be updated to:
>
>
> assertEquals("One instance should be held by the 'content' label", 1,
> ct);
>
> content = null;
> ct = 0;
> for (WeakReference<ScrollPane> ref : refs) {
> JMemoryBuddy.checkCollectable(ref);
> if (ref.get() != null) {
> ct++;
> }
> }
> assertEquals(ct + " References of ScrollPane are not freed.", 0, ct);
thank you
-------------
PR: https://git.openjdk.org/jfx/pull/900
