On Wed, 19 Oct 2022 12:51:21 GMT, Douglas Held <d...@openjdk.org> wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based >> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting >> in the method signatures of equals(), hashCode() and toString().~~ >> >> For good measure, some kind of copy/paste detection should probably be added >> to the many automated checks. For the entire OpenJDK project. > > Douglas Held has updated the pull request incrementally with one additional > commit since the last revision: > > Update Point3D.java > > Per review by nlisker I wouldn't want to take on this fix, as I'm not well educated in floating point types. I'm glad it is an identified issue. -- Douglas Held Senior Principal Security Consultant NetSuite Product Security Team ***@***.*** Note: Sent from a phone/microphone which may have introduced errors I didn’t catch On 19 Oct 2022, at 13:52, nlisker ***@***.***> wrote: I think there's something else of quality worth discussing here. Is == appropriate given the values under comparison are double? It's not. I have mentioned this exact case in https://bugs.openjdk.org/browse/JDK-8226930. I can assign it to you (or self-assign it yourself) if you want to work on it. If not, I will get to it at some point (no pun intended). This issue will require to go over the classes that override equals and see if they do it properly, including hashcode. Sometimes the equals implementation is "good enough", so there's not need to rewrite it in all the classes, but especially for public APIs, users should expect correct implementations. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/openjdk/jfx/pull/913*issuecomment-1283967929__;Iw!!ACWV5N9M2RV99hQ!IsvASiHZ8ACjFxfUOcVhZWtlmRTbKaoCiCpBaBYldXVwBbjFK7sBbCxdbMFlE8tugOMTSALYZlhMLKavyaX_x834$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANY5WT62LPS7D4OCIHMKSNTWD7VJZANCNFSM6AAAAAARDQAWZU__;!!ACWV5N9M2RV99hQ!IsvASiHZ8ACjFxfUOcVhZWtlmRTbKaoCiCpBaBYldXVwBbjFK7sBbCxdbMFlE8tugOMTSALYZlhMLKavyVbgoRIz$>. You are receiving this because you were mentioned.Message ID: ***@***.***> ------------- PR: https://git.openjdk.org/jfx/pull/913
