On Wed, 19 Oct 2022 18:18:48 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains ten commits: >> >> - Merge remote-tracking branch 'origin/master' into >> feature/conditional-bindings >> >> # Conflicts: >> # >> modules/javafx.base/src/test/java/test/javafx/beans/value/LazyObjectBindingTest.java >> - Fix review comments >> - Add missing new line >> - Small wording fixes >> - Update javadoc of "when" with better phrasing >> - Rename showing property to shown as it is already used in subclasses >> - Add conditional bindings to ObservableValue >> - Change explanatory comment to block comment >> - Fix bug where ObjectBinding returns null when revalidated immediately >> >> Introduced with the fluent bindings PR > > modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1442: > >> 1440: >> 1441: // Candidate to make publicly available or to add as a convience >> method to ObservableValue >> 1442: private static class ReadOnlyBooleanDelegate extends >> ReadOnlyBooleanProperty { > > should this class be moved elsewhere? It can be, generally I tend to this when there is a second use of the class. In that case we may also want to introduce the other primitive versions. So for now I would leave it here, until there is another use case. ------------- PR: https://git.openjdk.org/jfx/pull/830