On Tue, 22 Nov 2022 17:38:37 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "Fix warnings in fxml"
>>
>> This reverts commit b148aa3cc8a4676167a9eb8a023cddce3de116e7.
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/FXVKSkin.java
> line 750:
>
>> 748: protected void sendKeyEvents() {
>> 749: Node target = fxvk.getAttachedNode();
>> 750: if (chars != null) {
>
> not functionally equivalent:
> (instanceof EventTarget) here is equivalent to
> (!= null)
You are right, I've replaced this with a null check instead.
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/FXVKSkin.java
> line 858:
>
>> 856: protected void sendKeyEvents() {
>> 857: Node target = fxvk.getAttachedNode();
>> 858:
>
> same comment - check for null?
Yes, good catch, fixed.
-------------
PR: https://git.openjdk.org/jfx/pull/959
