On Wed, 23 Nov 2022 13:28:33 GMT, Kevin Rushforth <[email protected]> wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/IDisconnectable.java
>> line 34:
>>
>>> 32: */
>>> 33: @FunctionalInterface
>>> 34: public interface IDisconnectable {
>>
>> I'm still in favor of remove the `I` in front of this interface. This is
>> .NET convention and not used in Java (at least I never saw it, and thinking
>> of naming `Iterable` -> `IIterable` would be weird anyway.
>
> I made a [similar
> comment](https://github.com/openjdk/jfx/pull/908#pullrequestreview-1168974400)
> about not using the `I` prefix earlier. Before this can be considered for
> public API (which won't be soon), this interface will need to be renamed. It
> seems best to discuss what it should be renamed to as part of the larger
> discussion about the API surface, functionality, and naming, so I didn't ask
> that it be renamed now.
Agreed.
-------------
PR: https://git.openjdk.org/jfx/pull/908
