On Tue, 22 Nov 2022 23:43:24 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 28 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: review comments >> - 8294809: review comments >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: review comments >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: whitespace >> - 8294809: no public api >> - 8294809: map change listener >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - ... and 18 more: https://git.openjdk.org/jfx/compare/6ecba49e...00566eda > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ListenerHelper.java > line 79: > >> 77: private static Function<SkinBase<?>,ListenerHelper> accessor; >> 78: >> 79: public ListenerHelper(Object owner) { > > I note that this is unused, other than in unit tests. it is used in one of the skin draft PRs. > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ListenerHelper.java > line 94: > >> 92: } >> 93: >> 94: public IDisconnectable addDisconnectable(Runnable r) { > > I note that this is unused, other than in unit tests. also used in some draft skin PRs. ------------- PR: https://git.openjdk.org/jfx/pull/908
