On Wed, 23 Nov 2022 22:46:25 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/ConstrainedColumnResizeBase.java
>>  line 34:
>> 
>>> 32:  * @since 20
>>> 33:  */
>>> 34: public abstract class ConstrainedColumnResizeBase {
>> 
>> Do you think this class would benefit from a generic parameter for the 
>> specific type (`TableView.ResizeFeatures` or 
>> `TreeTableView.ResizeFeatures`)? In order for that to be useful, it would 
>> also need to extend `Callback` and declare an abstract call method using the 
>> generic type. I don't know whether this is worth it or not.
>
> Actually, this class (and `ConstrainedColumnResize`) do not need to be 
> generic.  I think it was a bit of oversight or perhaps 
> `TableColumnBase`/`ResizeFeaturesBase` was a late addition.

OK

-------------

PR: https://git.openjdk.org/jfx/pull/897

Reply via email to