On Mon, 5 Dec 2022 17:18:12 GMT, Andy Goryachev <[email protected]> wrote:

>> Karthik P K has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update in mouse enter and exit events. Update in unit test
>
> tests/system/src/test/java/test/robot/javafx/scene/SliderTooltipNPETest.java 
> line 85:
> 
>> 83: 
>> 84:     private void dragSliderAfterTooltipDisplayed(int dragDistance) 
>> throws Exception {
>> 85:         Thread.sleep(1000); // Wait for slider to layout
> 
> is there an equivalent of waitForIdle()?
> 
> could we replace the sleep() with waiting for some event/property instead?

Here I followed the same pattern used in other system tests such as 
TabPaneDragPolicyTest and ColorPickerTest.
visibleProperty is present for slider but no function is available to handle 
the event when this peoperty changes.
Please let me know if you have any suggestions.

-------------

PR: https://git.openjdk.org/jfx/pull/965

Reply via email to